Added show create pipe/database/topic#17702
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17702 +/- ##
============================================
+ Coverage 40.26% 40.37% +0.11%
- Complexity 2574 2575 +1
============================================
Files 5179 5183 +4
Lines 349659 349904 +245
Branches 44688 44707 +19
============================================
+ Hits 140798 141288 +490
+ Misses 208861 208616 -245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Caideyipi
changed the title
|
luoluoyuyu
left a comment
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review summary
Adds SHOW CREATE DATABASE / PIPE / TOPIC for table model with integration tests. Large surface area across parser, planner, and execution.
Please fix CI failures in this PR and ensure permission checks for system objects are covered in ITs.
| } | ||
|
|
||
| @Test | ||
| public void testShowCreateDatabase() throws SQLException { |
There was a problem hiding this comment.
testShowCreateDatabase asserts exact CREATE DATABASE text including region group defaults. If defaults change between releases, consider matching on key substrings to reduce brittle IT failures.
2 participants
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR